[orders] support reaction-specific item traits #1906
Conversation
myk002
force-pushed
the
myk_orders_reactions
branch
from
9b5df91
to
35f4171
Compare
| end | ||
|
|
||
| function check_import_success(file_content) | ||
| function check_import_success(file_content, comment, num_expected_orders) |
There was a problem hiding this comment.
Minor thing: comment is unused. If it makes sense to include in failure messages, I suggest passing it through as the comment argument to the two expect.eq calls below to provide more context (or you could take the approach of check_import_fail() and create fancier error messages). Alternatively, the comment argument could be removed, given that test failure tracebacks should be enough to isolate the cause of the failure now.
There was a problem hiding this comment.
Fixed. Passed comment through to the expect.eq calls, which was my original intention. The full tracebacks have definitely superseded comments for identifying which test failed, but I still find comments useful for reminding myself what the heck I'm actually testing if it's not completely obvious.
so the manager_order_next_id state can be set to #orders
myk002
force-pushed
the
myk_orders_reactions
branch
from
35f4171
to
f47bab9
Compare
implemented for both import and export
uses the new test wrapper functionality to export current orders, run the test, clear orders, import the player's previous orders, and remove temp files. this prevents the tests from having visible side effects. The tests will reset the next order id, but this isn't visible to the player.