Search options builder for search adapter #52
Conversation
| @@ -88,54 +87,18 @@ public async Task Search_SendsCorrectRequestToSearchService() | |||
| searchOptionsPassedToSearchService?.Facets.Should().BeEquivalentTo(searchServiceAdapterRequest.Facets); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Missing test to check that the SearchOptionsBuilder is called correctly?
There was a problem hiding this comment.
So are you talking about adding verifications for everything we inject into the constructor, think this was a test you put in originally so did enough to correct based on the revised dependency?
There was a problem hiding this comment.
For a unit test I would test that everything I pass into SearchAsync is passed on to the calls made from within the method, so I suppose in this case, I could check that every method of the builder class is called, or I could check that the _searchByKeywordService.SearchAsync method is called with all the right values .. which is almost done, except that not all of the searchOptions passed in are checked.
If I comment out lines 83-85 in the CognitiveSearchAdapter::SearchAsync method, no tests fail, so the test that's called Search_SendsCorrectRequestToSearchService isn't checking that everything is sent
There was a problem hiding this comment.
... but if you're saying that I hadn't tested it properly before, then I apologise, but I think we knew that, which was the reason for doing the refactor - so it was easier to test?
…s vased on PR feedback
No description provided.