Scrape custom metrics #3234
Merged
Scrape custom metrics #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
approved these changes
Jul 10, 2024
RMcVelia
force-pushed
the
1889-scrape-custom-metrics
branch
from
36f2202 to
fb470d6
Compare
|
Review app deployed to https://get-school-experience-review-pr-3234.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/Zlih3dRZ/1889-scrape-custom-metrics
Context
Scrape custom metrics that are exported for gse,
which can then be used in dashboards and alerting
Changes proposed in this pull request
Add enable_prometheus_monitoring to application deployments and set for each env
remove from review apps before merge
Guidance to review
make development terraform-plan IMAGE_TAG=x
Review app metrics are visible in prometheus test (yabeda-rails, sidekiq, http_requests, puma)