Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataset name gcp config #1282

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix dataset name gcp config #1282

merged 1 commit into from
Dec 17, 2024

Conversation

neillturner
Copy link
Contributor

Context

Fix dataset name gcp terraform config for production and preprod

Changes proposed in this pull request

add dataset name for gcp for production and preprod

Guidance to review

review code correct

Link to Trello card

RSM: migrate to GCP WIF

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@neillturner neillturner requested a review from a team as a code owner December 16, 2024 15:21
@neillturner neillturner requested review from vipin-dfe and removed request for a team December 16, 2024 15:22
Copy link

github-actions bot commented Dec 16, 2024

Review app refer serious misconduct deployed to https://refer-serious-misconduct-1282.test.teacherservices.cloud was deleted

@neillturner
Copy link
Contributor Author

RSM: migrate to GCP WIF

Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neillturner neillturner merged commit 0ea780b into main Dec 17, 2024
14 checks passed
@neillturner neillturner deleted the fix-dataset-name branch December 17, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants