Allowing IP restriction for RSM apps as part of RSM migration activity #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaheislamdfe
requested review from
vipin-dfe
and removed request for
a team
saliceti
reviewed
Nov 25, 2024
shaheislamdfe
force-pushed
the
2131-rsm-migrate-domains-to-s189-ip-restriction
branch
3 times, most recently
from
4948081 to
a24be96
Compare
saliceti
approved these changes
Nov 25, 2024
shaheislamdfe
force-pushed
the
2131-rsm-migrate-domains-to-s189-ip-restriction
branch
from
a24be96 to
45879cd
Compare
shaheislamdfe
deleted the
2131-rsm-migrate-domains-to-s189-ip-restriction
branch
shaheislamdfe
temporarily deployed
to
aks-review
GitHub Actions
Inactive
|
Review app refer serious misconduct deployed to https://refer-serious-misconduct-1243.test.teacherservices.cloud was deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Allowing IP restriction for RSM apps as part of RSM migration activity
Changes proposed in this pull request
Changing app.tf ip restriction values from 'Deny' to 'Allow'
Guidance to review
Link to Trello card
https://trello.com/c/8gYKfnWH/2131-rsm-migrate-domains-to-s189
Checklist