Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate review app #1238

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Migrate review app #1238

merged 2 commits into from
Nov 13, 2024

Conversation

vipin-dfe
Copy link
Contributor

@vipin-dfe vipin-dfe commented Nov 13, 2024

Context

Migrate rsm review apps from s615 subscription.

Changes proposed in this pull request

CI pipeline jobs have been deprecated as they are no longer needed once the review apps are running on aks.

Guidance to review

Only changes are in the github ci pipeline jobs

Link to Trello card

https://trello.com/c/koHmy9Xb

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

Copy link
Contributor

@neillturner neillturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just deleting old review app workflows and leaving new aks workflows

@vipin-dfe vipin-dfe marked this pull request as ready for review November 13, 2024 16:28
@vipin-dfe vipin-dfe requested a review from a team as a code owner November 13, 2024 16:28
@vipin-dfe vipin-dfe requested review from aje54 and removed request for a team November 13, 2024 16:28
@vipin-dfe vipin-dfe merged commit 5d192b8 into main Nov 13, 2024
6 checks passed
@vipin-dfe vipin-dfe deleted the migrate_review_app branch November 13, 2024 16:40
Copy link

Review app refer serious misconduct deployed to https://refer-serious-misconduct-1238.test.teacherservices.cloud was deleted

@vipin-dfe
Copy link
Contributor Author

RSM: migrate review apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants