change max file upload count to 20

DFE-Digital · Nov 20, 2023 · 50a75fb · 50a75fb
1 parent 44b8f25
commit 50a75fb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 24 deletions.
diff --git a/app/validators/file_upload_validator.rb b/app/validators/file_upload_validator.rb
@@ -2,7 +2,7 @@ class FileUploadValidator < ActiveModel::EachValidator
   include FileSizeHelper
 
   MAX_FILE_SIZE = 50.megabytes
-  MAX_FILES = 10
+  MAX_FILES = 20
 
   CONTENT_TYPES = {
     ".apng" => "image/apng",

diff --git a/spec/forms/referrals/allegation_evidence/upload_form_spec.rb b/spec/forms/referrals/allegation_evidence/upload_form_spec.rb
@@ -67,19 +67,11 @@
       end
 
       it "validates that the maximum number of files is not exceeded" do
-        upload_form.evidence_uploads = [
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
-          fixture_file_upload("upload.txt"),
+        upload_form.evidence_uploads = (described_class::MAX_FILES - 1).times.map do
           fixture_file_upload("upload.txt")
-        ]
+        end
         expect(upload_form.save).to be false
-        expect(upload_form.errors[:evidence_uploads]).to eq(["You can only upload 10 files"])
+        expect(upload_form.errors[:evidence_uploads]).to eq(["You can only upload 20 files"])
       end
     end
   end

diff --git a/spec/validators/file_upload_validator_spec.rb b/spec/validators/file_upload_validator_spec.rb
@@ -42,19 +42,9 @@
 
   context "with too many files" do
     let(:files) do
-      [
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
-        fixture_file_upload("upload1.pdf", "application/pdf"),
+      (described_class::MAX_FILES + 1).times.map do
         fixture_file_upload("upload1.pdf", "application/pdf")
-      ]
+      end
     end
 
     it { is_expected.to be_invalid }