Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade dfe-analytics to 1.12.3 #536

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Downgrade dfe-analytics to 1.12.3 #536

merged 1 commit into from
Apr 26, 2024

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Apr 26, 2024 •
edited
Loading

Context

The 1.12.4 has some changes that breaks the importing of entities to BigQuery. I will raise an issue with the dfe-analytics team but for now 1.12.3 should work for us.

The issue seems to be in this PR DFE-Digital/dfe-analytics#132

The SQL syntax seems to be incorrect looking at https://dfe-teacher-services.sentry.io/issues/5259551627/events/76d8bafa5cc44fa3b063a78fbfeb4183/

ActiveRecord::StatementInvalid
PG::SyntaxError: ERROR:  syntax error at or near "2024" (ActiveRecord::StatementInvalid)
LINE 7: ...ships".updated_at) < DATE_TRUNC('milliseconds', ''2024-04-26...

Changes proposed in this pull request

Downgrade the gem to 1.12.3

Guidance to review

Review

Screenshot from 2024-04-26 12-00-37

@CatalinVoineag
Downgrade dfe-analytics to 1.12.3
195deaf 
The 1.12.4 has some changes that breaks the importing of entities to
BigQuery. I will raise an issue with the dfe-analytics team but for now
1.12.3 should work for us.
@CatalinVoineag CatalinVoineag self-assigned this Apr 26, 2024
@CatalinVoineag CatalinVoineag marked this pull request as ready for review April 26, 2024 11:00
@CatalinVoineag CatalinVoineag merged commit 67f37c6 into main Apr 26, 2024
8 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/downgrade-dfe-analytics branch April 26, 2024 11:44
@CatalinVoineag CatalinVoineag mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gms-gs gms-gs gms-gs approved these changes

@Nitemaeric Nitemaeric Nitemaeric approved these changes

Assignees

@CatalinVoineag CatalinVoineag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CatalinVoineag @Nitemaeric @gms-gs