-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Life as a teacher description update #4202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmaachesongray
temporarily deployed
to
review
September 18, 2024 12:31
— with
GitHub Actions
Inactive
Sarah-DfE
previously approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
emmaachesongray
commented
Sep 19, 2024
emmaachesongray
temporarily deployed
to
review
September 19, 2024 12:56
— with
GitHub Actions
Inactive
emmaachesongray
commented
Sep 19, 2024
emmaachesongray
temporarily deployed
to
review
September 19, 2024 13:33
— with
GitHub Actions
Inactive
Review app deployed to https://get-into-teaching-app-review-4202.test.teacherservices.cloud |
Sarah-DfE
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
emmaachesongray
temporarily deployed
to
review
September 19, 2024 14:54
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/mdzfNdDZ/6545
Context
We recently finished adding all 4 new subcategory pages to the life of a teacher section.
Changes proposed in this pull request
Now this section is complete, we should update the meta description on the life as a teacher page so it fully reflects the range of topics within the section. This will help users find content through organic search.
Guidance to review