Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add simple feature flag for feedback that can be enabled / disabled per env" #3677

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Revert "Add simple feature flag for feedback that can be enabled / disabled per env" #3677

merged 1 commit into from
Nov 3, 2023

Conversation

StackedPancakez
Copy link
Contributor

Reverts #3655

Reinstate feedback pages.

@github-actions github-actions bot added ruby Pull requests that update Ruby code Config labels Nov 2, 2023
@StackedPancakez StackedPancakez temporarily deployed to review_aks November 2, 2023 07:54 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Review app deployed to https://review-get-into-teaching-app-3677.london.cloudapps.digital

@github-actions github-actions bot added the Review label Nov 2, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

AKS Review app deployed to https://get-into-teaching-app-review-3677.test.teacherservices.cloud

@github-actions github-actions bot added the Review_v2 Create AKS review app label Nov 2, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

96.2% 96.2% Coverage
0.2% 0.2% Duplication

gemmadallmandfe
gemmadallmandfe approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a front-end perspective

Does this need a tech review as well?

asatwal
asatwal approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@StackedPancakez StackedPancakez merged commit 4a36369 into master Nov 3, 2023
24 checks passed
@StackedPancakez StackedPancakez deleted the revert-3655-create-simple-feedback-feature-flag-for-env-migration branch November 3, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

@asatwal asatwal asatwal approved these changes

Assignees
No one assigned
Labels
Config Review_v2 Create AKS review app Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StackedPancakez @asatwal @gemmadallmandfe