Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove applications open inset text #3646

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

StackedPancakez
Copy link
Contributor

Trello card

5180

Context

The banner informing of application opening is no longer needed so removing.

Changes proposed in this pull request

Remove the inset text from erb template and regenerate view file.

Guidance to review

Ensure the banner is removed on the review apps.

@StackedPancakez StackedPancakez added Review Review_v2 Create AKS review app labels Oct 24, 2023
@github-actions github-actions bot added the content Content changes label Oct 24, 2023
@StackedPancakez StackedPancakez temporarily deployed to Review October 24, 2023 08:34 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to review_aks October 24, 2023 08:34 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

97.2% 97.2% Coverage
0.2% 0.2% Duplication

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gemmadallmandfe gemmadallmandfe merged commit 45bb74f into master Oct 24, 2023
30 checks passed
@gemmadallmandfe gemmadallmandfe deleted the remove-inset-text-for-application-opening branch October 24, 2023 09:58
@gemmadallmandfe gemmadallmandfe temporarily deployed to review_aks October 24, 2023 09:58 — with GitHub Actions Inactive
@gemmadallmandfe gemmadallmandfe temporarily deployed to Review October 24, 2023 09:58 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review_v2 Create AKS review app Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants