Fix alignment issues on landing page headers #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethwilliamsdesign
requested review from
gemmadallmandfe and
StackedPancakez
garethwilliamsdesign
temporarily deployed
to
Review
GitHub Actions
Inactive
garethwilliamsdesign
temporarily deployed
to
review_aks
GitHub Actions
Inactive
|
Review app deployed to https://review-get-into-teaching-app-3642.london.cloudapps.digital |
|
AKS Review app deployed to https://get-into-teaching-app-review-3642.test.teacherservices.cloud |
|
Kudos, SonarCloud Quality Gate passed! |
gemmadallmandfe
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Looks good to me @garethwilliamsdesign - I've tested multiple pages using this template on desktop and mobile (iPhone 11)
Happy for this to be merged once @StackedPancakez has approved
garethwilliamsdesign
temporarily deployed
to
Review
GitHub Actions
Inactive
garethwilliamsdesign
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Trello 5160
Context
H1s on the alternate template pages are misaligned when wrapping is involved.
Changes proposed in this pull request
Fix the alignment issue by using the
box-decoration-breakproperty.Guidance to review
Check that the alignment issue is no longer present on alternate template pages such as /subjects/maths and /landing/how-much-do-teachers-get-paid.