Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose your course guidance retry #3625

Merged
merged 13 commits into from
Oct 27, 2023
Merged

Choose your course guidance retry #3625

merged 13 commits into from
Oct 27, 2023

Conversation

StackedPancakez
Copy link
Contributor

Retry rebase and PR for #3606 so please check there for info about PR and the work done.

@github-actions github-actions bot added the content Content changes label Oct 18, 2023
@StackedPancakez StackedPancakez temporarily deployed to review_aks October 18, 2023 15:38 — with GitHub Actions Inactive
@StackedPancakez StackedPancakez temporarily deployed to Review October 18, 2023 15:38 — with GitHub Actions Inactive
@github-actions github-actions bot added Review Review_v2 Create AKS review app labels Oct 18, 2023
@philspraydfe philspraydfe mentioned this pull request Oct 19, 2023
Closed
@philspraydfe philspraydfe temporarily deployed to Review October 19, 2023 09:24 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to review_aks October 19, 2023 09:24 — with GitHub Actions Inactive
@laurahermionetennant92
Copy link
Contributor

Hi @philspray, comments from me as follows :)
In general, I wondered if it would be helpful to include age, subject and location at the top under 'the main differences'?
Then for non-UK:
Thanks for including the link to the visa page. For this to work for non-UK applicants we would probably also need caveats/extra info/links to our pages under:

  • Quals you'll need for teacher training
  • Funding you will get (or won't get)
  • Salaried courses (stronger caveat to indicate very few non-UK trainees get on these courses)

Under course provider section, things to ask:

  • timings for non-UK applicants (still open?)
  • visa sponsorship

Thank you

@philspraydfe philspraydfe temporarily deployed to Review October 19, 2023 11:05 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to review_aks October 19, 2023 11:05 — with GitHub Actions Inactive
gemmadallmandfe
gemmadallmandfe reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments @philspray

app/views/content/train-to-be-a-teacher/how-to-choose-your-teacher-training-course.md Outdated Show resolved Hide resolved
app/views/content/train-to-be-a-teacher/how-to-choose-your-teacher-training-course.md Outdated Show resolved Hide resolved
app/views/content/train-to-be-a-teacher/how-to-choose-your-teacher-training-course.md Outdated Show resolved Hide resolved
app/views/content/train-to-be-a-teacher/how-to-choose-your-teacher-training-course.md Outdated Show resolved Hide resolved
app/views/content/train-to-be-a-teacher/how-to-choose-your-teacher-training-course.md Outdated Show resolved Hide resolved
app/views/content/train-to-be-a-teacher/how-to-choose-your-teacher-training-course.md Outdated Show resolved Hide resolved
@philspraydfe philspraydfe temporarily deployed to review_aks October 24, 2023 13:01 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to review_aks October 24, 2023 13:41 — with GitHub Actions Inactive
@philspraydfe philspraydfe requested a deployment to review_aks October 24, 2023 14:47 — with GitHub Actions Abandoned
@philspraydfe philspraydfe temporarily deployed to Review October 24, 2023 14:47 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to Review October 25, 2023 12:51 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to review_aks October 25, 2023 12:51 — with GitHub Actions Inactive
@github-actions
Copy link

Review app deployed to https://review-get-into-teaching-app-3625.london.cloudapps.digital

@github-actions
Copy link

AKS Review app deployed to https://get-into-teaching-app-review-3625.test.teacherservices.cloud

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

97.2% 97.2% Coverage
0.2% 0.2% Duplication

gemmadallmandfe
gemmadallmandfe approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - happy for this to be merged tomorrow morning (Friday)

@philspraydfe philspraydfe merged commit 621a3c1 into master Oct 27, 2023
27 checks passed
@philspraydfe philspraydfe deleted the choose-your-course-guidance-retry branch October 27, 2023 07:47
@philspraydfe philspraydfe temporarily deployed to Review October 27, 2023 07:47 — with GitHub Actions Inactive
@philspraydfe philspraydfe temporarily deployed to review_aks October 27, 2023 07:47 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

@philspraydfe philspraydfe Awaiting requested review from philspraydfe

Assignees
No one assigned
Labels
content Content changes Review_v2 Create AKS review app Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StackedPancakez @laurahermionetennant92 @gemmadallmandfe @philspraydfe @EllieNodder