This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Use footer component from govuk-components gem #621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After discussion with @peteryates about allowing more customisation of the footer component in the
govuk-components
gem (x-govuk/govuk-components#95), this PR previews the resulting change on Find.Ultimately, because our current footer design deviates from the layouts allowable by the Design System, in effect all that this component does is replace the following containing elements:
This feels like a good compromise. Should the design of the footer align more closely to the design of the Design System component in the future, we can use more of the options provided by this gem.
Changes proposed in this pull request
Happy with this approach?
Guidance to review
Pending release of the next version of the
govuk-components
gem.Checklist