Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Use footer component from govuk-components gem #621

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

paulrobertlloyd
Copy link
Contributor

Context

After discussion with @peteryates about allowing more customisation of the footer component in the govuk-components gem (x-govuk/govuk-components#95), this PR previews the resulting change on Find.

Ultimately, because our current footer design deviates from the layouts allowable by the Design System, in effect all that this component does is replace the following containing elements:

<footer class="govuk-footer govuk-!-display-none-print" role="contentinfo">
  <div class="govuk-width-container">
    <div class="govuk-footer__meta"></div>
  </div>
</div>

This feels like a good compromise. Should the design of the footer align more closely to the design of the Design System component in the future, we can use more of the options provided by this gem.

Changes proposed in this pull request

Happy with this approach?

Guidance to review

Pending release of the next version of the govuk-components gem.

Checklist

  • Rebased master
  • Cleaned commit history
  • Tested by running locally

@paulrobertlloyd paulrobertlloyd marked this pull request as ready for review January 25, 2021 11:26
Copy link
Contributor

@stevehook stevehook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Markup looks good. Testing locally looks identical to the original.

@paulrobertlloyd paulrobertlloyd merged commit db70537 into master Jan 26, 2021
@paulrobertlloyd paulrobertlloyd deleted the footer-component branch January 26, 2021 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants