Update entity_check_job to loop through entities only #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asatwal
reviewed
Nov 24, 2023
There was a problem hiding this comment.
A few comments as I've noticed a few things. I also got errors when running locally as the checksum_calculated_at was a little out. I had to add Timecop.
I'll push a commit to fix review comments and added Timecop.
Also removed model altogether from entity checksum.
Could you take a look please.
I'm going to test this in Register staging overnight. We can then merge if all OK. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed after testing on Register, that the entity_check_job would loop through sub-types causing an extra event to be sent to BQ.
This PR updates the perform method to loop through entities only and updates the build_event_for method to handle entity_name rather than model. The logger message had to be moved too.