Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DfE::Analytics crashing on installation #93

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Fix for DfE::Analytics crashing on installation #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e16cbec
Testing update
ericaporter Oct 17, 2023
61ecb1b
Debugging
ericaporter Oct 17, 2023
386f6ee
More debugging
ericaporter Oct 17, 2023
fc9f5a0
Remove whitespace
ericaporter Oct 17, 2023
abb4967
Fix file name
ericaporter Oct 17, 2023
3dd8369
Update conditional, print to console
ericaporter Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/dfe/analytics.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ def self.initialize!
return
end

unless Rails.env.production? || File.exist?(Rails.root.join('config/initializers/dfe_analytics.rb'))
message = "Warning: DfE Analytics is not set up. Run: 'bundle exec rails generate dfe:analytics:install'"
Rails.logger.info(message)
puts message
return
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my brain, unless || is easier to read but happy to update to if !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Randomly saw this. First time I see unless || described as easier to read 😅. I personally avoid it.

Copy link
Contributor Author

@ericaporter ericaporter Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, well, imo it follows the pattern with the other unless just above it, plus I think easier than if doesn't && doesn't @vassyz, but I shall bear that in mind next time I use unless


raise ActiveRecord::PendingMigrationError if ActiveRecord::Base.connection.migration_context.needs_migration?

DfE::Analytics::Fields.check!
Expand Down
0 ...ummy/config/initializers/dfe-analytics.rb → ...ummy/config/initializers/dfe_analytics.rb
View file
Open in desktop
File renamed without changes.
Loading