Add log message for entities without primary_key, update README.rb #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asatwal
approved these changes
Sep 27, 2023
| primary_key = model.primary_key | ||
|
|
||
| if primary_key.nil? | ||
| Rails.logger.info("Not processing #{@entity_name} as it does not have a primary key") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dfe-analyticsdoes not load entities if they do not have a primary key. This issue was discovered when ECF (CPD) were installing the gem and were unable to load a join table which did not have a primary key.It was decided to update the error messaging / readme to ask that a primary key to be added to the entity in these situations.
This PR includes these additions (1. update to logging message 2. update to README.rb)
Updates to the loading strategy, to make it more robust, will be considered in future.