Prevent duplicate fields in blocklist when using STI #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the application has models that are configured with single table
inheritance the generated blocklist will contain duplicate field names for
the table (once for each model).
This is due to the behaviour of `attribute_names` in Rails; it retrieves
the names directly from the table columns and doesn't filter based on the
context of the subclass.
To avoid this we need to `uniq` the attribute names generated for the
blocklist.
Example blocklist prior to change (assuming a parent/child using STI):
```
{:with_model_candidates_43990_9360=>["id", "first_name", "id", "first_name"]}
```
And after change:
```
{:with_model_candidates_43990_9360=>["id", "first_name"]}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the application has models that are configured with single table inheritance the generated blocklist will contain duplicate field names for the table (once for each model).
This is due to the behaviour of
attribute_namesin Rails; it retrieves the names directly from the table columns and doesn't filter based on the context of the subclass.To avoid this we need to
uniqthe attribute names generated for the blocklist.Example blocklist prior to change (assuming a parent/child using STI):
And after change: