Do not attempt initialization when the user is changing the database #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db:* rake commands are often useful to bring the database into line with what DfE::Analytics expects, so it can be painful not to be able to run them when the config is inconsistent. Allow these commands at all times - full checks will run on app or test boot anyway.
asatwal
reviewed
Jun 29, 2023
| @@ -34,7 +34,15 @@ class Railtie < Rails::Railtie | |||
| config.after_initialize do | |||
| # internal gem tests will sometimes suppress this so they can test the | |||
| # init process | |||
| DfE::Analytics.initialize! unless ENV['SUPPRESS_DFE_ANALYTICS_INIT'] | |||
| if running_db_rake_task? || ENV['SUPPRESS_DFE_ANALYTICS_INIT'] | |||
There was a problem hiding this comment.
db: commands can also be invoked using rails, so possibly need to cater for rails invocation also.
|
rails uses Rake under the hood, so this works for rails too!
|
thomasleese
approved these changes
Jun 30, 2023
| end | ||
|
|
||
| def running_db_rake_task? | ||
| defined?(Rake) && Rake.application.top_level_tasks.any? { |t| t.start_with?('db:') } |
There was a problem hiding this comment.
I was trying to see if there was a way we could look at the namespace of the tasks rather than looking at what it starts with, but couldn't work out a nice way of doing it, so this seems fine.
There was a problem hiding this comment.
Yeah, it's a bit ick. But it does seem to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db:* rake commands are often useful to bring the database into line with what DfE::Analytics expects, so it can be painful not to be able to run them when the config is inconsistent. Allow these commands at all times - full checks will run on app or test boot anyway.
I couldn't think of a reasonable way to test this!