Run specs on all PRs (and fix a flaky spec) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanjbrown
force-pushed
the
ci
branch
3 times, most recently
from
098b112 to
719f505
Compare
Before this change, the descendant "Candidate" class would hang around outside the spec, which caused an order dependent failure in fields_spec.rb. Explictly calling stub_const and/or declaring the descendant outside the controller definition seems to force RSpec/Ruby to clean up the ref after the test is run, and the order-dependent failure goes away.
duncanjbrown
changed the title
tomas-stefano
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.