Add better error logging when calling BigQuery insert API on error #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asatwal
force-pushed
the
log-event-on-failed-api-call
branch
from
6164eb1 to
dad72ce
Compare
|
Coming late to the party to say thank you for how quickly actioned this 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello-1253
Currently when doing a full import on the Teaching Vacancies App, calls to the BigQuery insert API are failing.
There are very few clues in the error logs as to which events are causing the failures. As the full import calls the BigQuery insert API in batches of 500, it's also very difficult to pinpoint the event causing the failure.
This PR adds better error logging when calling the API and logs the events causing the failures also.