Support single table inheritance #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-G
approved these changes
Jun 28, 2023
duncanjbrown
force-pushed
the
single-table-inheritance
branch
from
c2cdd79 to
552bd0a
Compare
duncanjbrown
changed the title
asatwal
approved these changes
Jun 28, 2023
|
Looks like it's broken on Ruby 2.7/Rails 6.1. I'm going to check whether anyone's even on that stack |
|
oh, it's an order-dependent failure due to spec activerecord trickery — will fix |
When apps use single-table inheritance, multiple Rails models share the same database table - i.e. they are considered a single 'entity' by DfE Analytics. This isn't good, because it means that at most one model can be associated with a single table. In turn this means that we will not know to attach callbacks to the other models in the STI heirarchy. In practice, due to the order in which ActiveRecord::Base.descendants returns the models, this seems to be the alphabetically first child, not the parent, and not any of the siblings. Treating the right hand side of the mapping as a list of models, not a single model, allows us to handle this. We have to update the code in a couple places to expect arrays instead of strings.
duncanjbrown
force-pushed
the
single-table-inheritance
branch
from
552bd0a to
68a5e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When apps use single-table inheritance, multiple Rails models share the same database table - i.e. they are considered a single 'entity' by DfE Analytics.
This isn't good, because it means that at most one model can be associated with a single table. In turn this means that we will not know to attach callbacks to the other models in the STI heirarchy. In practice, due to the order in which
ActiveRecord::Base.descendantsreturns the models, this ends up being the alphabetically first child — not the parent, and not any of the siblings.Added DNM so @JR-G can test it out on Apply first!Confirmed working on Apply