Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor wording fixes #74

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Minor wording fixes #74

merged 2 commits into from
Jun 29, 2023

Conversation

scruti
Copy link
Contributor

@scruti scruti commented May 4, 2023

When going through the gem's codebase, I noticed a couple of places where the wording was incorrect or needed to be upgraded:

  • Wrong task description matching another rake task.
  • A command message displaying a deprecated interface call for a rake task.

scruti added 2 commits May 4, 2023 14:52
It was a copy&paste of the "regenerate_blocklist" task.
To match the new gem interface "dfe:analytics:task"
Copy link
Contributor

@duncanjbrown duncanjbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 thank you!

@asatwal asatwal merged commit 9d7cdb4 into DFE-Digital:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants