Update advice on queue config and running imports #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/locales/en.yml
Outdated
| @@ -12,7 +12,7 @@ en: | |||
| default: true | |||
| queue: | |||
| description: Which ActiveJob queue to put events on | |||
| default: ":default" | |||
| default: ":dfe_analytics" | |||
There was a problem hiding this comment.
This is now at odds with
dfe-analytics/lib/dfe/analytics.rb
Line 79 in 86ebf54
duncanjbrown
approved these changes
Feb 23, 2023
asatwal
force-pushed
the
add-more-advice-to-readme
branch
from
42cb68d to
dd31c2a
Compare
Yes, good point to have it working OOB. Restored actual config and left advice in the README. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello-887
Add following advice to README.md: