-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Matched Events #63
Conversation
ac9b11c
to
39c9238
Compare
9b3a14a
to
1bd975d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Comments inline. I think there are a couple more things to think about re nested fields, and I'm not convinced we need to support them at this stage (unless something has changed), so I've proposed keeping this PR minimal and focussed on the use case at hand, ie matching top-level strings in the event payload.
@duncanjbrown - Thanks for the review. Some very useful feedback. I've added corrections and hopefully clarified the nested fields. We can remove the matching of nested fields and match at the top level only, that would simplify. I've explained the nested fields through examples, so maybe we can add the examples below to the READ.me ? Or we can remove altogether, I'm not too fussed either way. I think it's not too complex, but then again I implemented this. I'll let you decide :-) |
2d016b3
to
c29723a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brill, thanks for changes @asatwal !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; I think @duncanjbrown should approve though rather than me.
Trello-975
Create an events filter for logging, so that we log only the events of interest. This will allow targeted logging for diagnostic and debugging purposes.
The events filter is held in a YAML config.
Event filter example: