Allowing pushing custom events #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,6 +119,12 @@ def self.blocklist | |||
| Rails.application.config_for(:analytics_blocklist) | |||
| end | |||
|
|
|||
| def self.custom_events | |||
| Rails.application.config_for(:analytics_custom_events) | |||
| rescue RuntimeError | |||
There was a problem hiding this comment.
Bad Rails not returning specific exception type in this context!
There was a problem hiding this comment.
I know, right! I was actually considering checking first if the file exists and let it fail in case of syntax error. This would be probably a better option here?
There was a problem hiding this comment.
It's painful, but I think I'd rather live with generic exception than break the abstraction of config_for? wdyt?
| @@ -177,6 +178,33 @@ DfE::Analytics.config.queue = :default | |||
|
|
|||
| Alternatively you may consider setting the priority of the jobs according to your chosen ActiveJob adapter's conventions. | |||
|
|
|||
| ### 8. Custom events | |||
|
|
|||
| If you wish to send custom analytics event, create a file `config/analytics_custom_events.yml` containing an array of your custom events types under a `shared` key like: | |||
There was a problem hiding this comment.
Suggested change
| If you wish to send custom analytics event, create a file `config/analytics_custom_events.yml` containing an array of your custom events types under a `shared` key like: | |
| If you wish to send custom analytics events, create a file `config/analytics_custom_events.yml` containing an array of your custom event types under a `shared` key like: |
duncanjbrown
approved these changes
Jan 18, 2023
|
@duncanjbrown can you merge this for us please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change allows all the users to define the custom events they would like to push to analytics database.