Recover when the database hasn’t been set up yet #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually throw a MigrationPending exception if needed, or in cases where app code begins executing before migration has run (eg worker instances that override default Docker entrypoints) and there is no DB schema yet (eg review apps) we get an error saying that the whole schema needs to be put into the blocklist
duncanjbrown
force-pushed
the
fix-review-apps
branch
from
9af9aec to
97e3ddd
Compare
saliceti
approved these changes
Oct 5, 2022
Also strengthen log line assertions in specs, we should expect, not allow
saliceti
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And another build-related edge case 😅
Manually throw a MigrationPending exception, or else, in cases where app code begins executing before migration has run (eg worker instances that override default Docker entrypoints) and there is no DB schema yet (eg review apps), we get an error saying that the whole schema needs to be put into the blocklist