Quietly fail init if no database is present #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing loudly under these circs context isn't helpful because it doesn't reflect a problem with the analytics setup; apps in CI often run the asset precompilation step without a database present.
duncanjbrown
force-pushed
the
recover-init-when-no-database
branch
from
678a644 to
03e2d00
Compare
|
This has built successfully on Publish (https://github.com/DFE-Digital/publish-teacher-training/actions/runs/3134716188/jobs/5089961606) so opening for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing loudly under these circs context isn't helpful because it doesn't reflect a problem with the analytics setup; apps in CI often run the asset precompilation step without a database present.
Currently testing against Publish in CI, will make reviewable once that's working