Change ActiveJob log level #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saliceti
approved these changes
Sep 16, 2022
|
Is there any value to setting the logging level to |
|
Interesting idea |
Just thinking it would still be good to see |
duncanjbrown
force-pushed
the
stop-logging
branch
from
856d86d to
0c7493b
Compare
saliceti
approved these changes
Sep 16, 2022
For Rails 6.0, which doesn't support this, turn of :info logging altogether.
duncanjbrown
force-pushed
the
stop-logging
branch
from
0c7493b to
c27c002
Compare
slorek
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was necessary to defer setting the logger to after ActiveJob had loaded, because ActiveJob sets a logger in its own Railtie.
https://github.com/rails/rails/blob/a5018cf149d47e1aed1e74dd35e4d519b507c364/activejob/lib/active_job/railtie.rb#L13-L15