Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user id field to be configurable #42

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

misaka
Copy link
Contributor

@misaka misaka commented Aug 18, 2022

Some systems may not be able to, or prefer not to, use the id attribute
on user to identify the user. Allow these systems to call a different
method on the user to return an identifier.

This change should not break existing systems as defaults to using user.id as the previous systems did.

Some systems may not be able to, or prefer not to, use the id attribute
on user to identify the user. Allow these systems to call a different
method on the user to return an identifier.
Copy link
Collaborator

@ethax-ross ethax-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@misaka misaka changed the base branch from main to v1.2.0-release August 18, 2022 15:25
@misaka misaka changed the base branch from v1.2.0-release to main August 18, 2022 15:25
@duncanjbrown duncanjbrown merged commit 0461270 into main Aug 31, 2022
@duncanjbrown duncanjbrown deleted the make-user-id-configurable branch August 31, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants