Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GCloud install details and move to new file #41

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

misaka
Copy link
Contributor

@misaka misaka commented Aug 17, 2022

Add a bunch more detail to the instructions for setting up GCloud and move these instructions to a separate file.

This is a fairly messy change, soz. The key changes are:

  • move the instructions for setting up Google Cloud into a separate file docs/GOOGLE_CLOUD_BIGQUERY_SETUP.md
  • change Gemfile example to use GitHub
  • recommend creating a separate service account for each dataset instead of a single service account with access to all the datasets, plus additional explanations and examples
  • add more words to make it clearer what each step is doing
  • refer to Google Cloud over just "BigQuery". e.g. the project created is a Google Cloud project, not just a BigQuery project. This means these projects will have access to Google Maps APIs and other services in the GCP suite.

Add a bunch more detail to the instructions for setting up GCloud and
move these instructions to a separate file.
Copy link
Collaborator

@ethax-ross ethax-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great and it all makes sense; just a few minor things I noticed on reading through it.

docs/GOOGLE_CLOUD_BIGQUERY_SETUP.md Outdated Show resolved Hide resolved
docs/GOOGLE_CLOUD_BIGQUERY_SETUP.md Outdated Show resolved Hide resolved
docs/GOOGLE_CLOUD_BIGQUERY_SETUP.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@ethax-ross ethax-ross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor

@thomasleese thomasleese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've only got one comment, but it's not a big thing!

README.md Outdated Show resolved Hide resolved
@misaka misaka merged commit 40f63d3 into main Aug 18, 2022
@misaka misaka deleted the fill-in-gcloud-installation branch August 18, 2022 13:25
@misaka
Copy link
Contributor Author

misaka commented Sep 12, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants