Adopt with_model #36
Merged
Adopt with_model #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is significantly cleaner than setting up models in the dummy app Note that we must clear entity_model_mapping between specs to avoid state leakage - this isn't great but we can fix later
misaka
reviewed
Aug 5, 2022
There was a problem hiding this comment.
I really like this with_model thing, however, a couple concerns.
- I was wondering if the right way for us to check end-to-end integration with BigQuery is to use the dummy app that gets superceded by
with_modelhere. - We've removed the dummy apps models, but the controllers stay there. It could be nice to keep the dummy app as a more complete example of how to setup an app, which could integrate nicely the integration tests mentioned above.
So ... options:
- Use the dummy app for these purposes.
- Setup a separate dummy app for integration testing that also demonstrates how things are setup.
Also, is there a way to make models without requiring ActiveRecord? Something like active_attr? Although I think our other PR more closely ties us to ActiveRecord so maybe not.
|
As discussed:
|
|
updated! |
misaka
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this extremely useful gem which lets us declare the app's models at the top of specs instead of maintaining them as state in the dummy app 🙌 .
Migrate existing specs to it. I'll rebase the auto-init branch on top of this.