Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snake_case for config file #3

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Use snake_case for config file #3

merged 1 commit into from
Apr 26, 2022

Conversation

duncanjbrown
Copy link
Contributor

This doesn't make any difference in practice, but it will save new clients the trouble of renaming this file to appease Rubocop

This doesn't make any difference in practice, but it will save new
clients the trouble of renaming this file to appease Rubocop
@duncanjbrown duncanjbrown changed the title Rubocop doesn't like files with kebab-case Use snake_case for config file Apr 25, 2022
@duncanjbrown duncanjbrown requested a review from misaka April 25, 2022 13:26
duncanjbrown added a commit to DFE-Digital/find-teacher-training that referenced this pull request Apr 25, 2022
- non-space whitespace character
- dash in filename, which will be prevented by DFE-Digital/dfe-analytics#3
Copy link
Contributor

@misaka misaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍 FTRW!!!

@duncanjbrown duncanjbrown merged commit f087275 into main Apr 26, 2022
@duncanjbrown duncanjbrown deleted the rename-config-file branch April 26, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants