Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand setup instructions #28

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Expand setup instructions #28

merged 1 commit into from
Jul 1, 2022

Conversation

stevenleggdfe
Copy link
Contributor

  • Merge in instructions pulled together by Apply for QTS team
  • Add SQL query to generate blank events schema (instead of asking users to create the schema manually in the UI)
  • Add link to dfe-analytics-dataform repo

@stevenleggdfe
Copy link
Contributor Author

Agree and implement events table setup approach for new services onboarding to dfe-analytics

duncanjbrown
duncanjbrown reviewed Jun 29, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@duncanjbrown
Copy link
Contributor

I like this! Could we get around the massive chunk of SQL? I think it might scare people off a bit. Maybe include as a file? Also can you squish your commits pretty please? (Happy to help with this if wanted!)

@stevenleggdfe
Copy link
Contributor Author

I like this! Could we get around the massive chunk of SQL? I think it might scare people off a bit. Maybe include as a file? Also can you squish your commits pretty please? (Happy to help with this if wanted!)

Moved to separate file. However the 'comments' are actually metadata that the query is putting into the BQ table - sure you think they need squishing?

misaka
misaka reviewed Jul 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
misaka
misaka reviewed Jul 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
misaka
misaka reviewed Jul 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
misaka
misaka reviewed Jul 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
misaka
misaka reviewed Jul 1, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
misaka
misaka reviewed Jul 1, 2022
View reviewed changes
README.md Show resolved Hide resolved
@duncanjbrown duncanjbrown force-pushed the SL-merge-in-bq-setup-instructions branch from 6ac96b7 to 78a85ea Compare July 1, 2022 09:55
@stevenleggdfe
Update README.md
c033d4b 
- Add SQL query to generate table inside of asking installers to type out the schema and partitioning options themselves. This also includes some default metadata for the events table.
- Merge in documentation from Apply for QTS service's experience

Update README.md

Update README.md

Update README.md

Update README.md

Update README.md

Co-Authored-By: Misha Gorodnitzky <misha.gorodnitzky@digital.education.gov.uk>
@stevenleggdfe stevenleggdfe force-pushed the SL-merge-in-bq-setup-instructions branch from 5db5842 to c033d4b Compare July 1, 2022 13:24
misaka
misaka approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@misaka misaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stevenleggdfe stevenleggdfe merged commit 7c4993a into main Jul 1, 2022
@stevenleggdfe stevenleggdfe deleted the SL-merge-in-bq-setup-instructions branch July 1, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanjbrown duncanjbrown duncanjbrown left review comments

@misaka misaka misaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenleggdfe @duncanjbrown @misaka