Improve testing modes #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stub client, used in the fake testing mode, currently doesn't work as it's defined as only taking one argument, but in reality this method should accept two. Rather than hard coding the two arguments, I've defined it to accept any number of arguments. I've also added a test to avoid this issue from coming up again. I think it was 02dc49c which introduced this bug when using the fake testing mode.
This will mean users of this library have a better understanding of the testing modes available and how to use them.
thomasleese
added a commit
to DFE-Digital/apply-for-qualified-teacher-status
that referenced
this pull request
Jun 28, 2022
This changes the way we disable DfE Analytics in our tests by using the built-in DfE Analytics fake testing mode. Note that this depends on DFE-Digital/dfe-analytics#26.
thomasleese
added a commit
to DFE-Digital/apply-for-qualified-teacher-status
that referenced
this pull request
Jun 28, 2022
This changes the way we disable DfE Analytics in our tests by using the built-in DfE Analytics fake testing mode. Note that this depends on DFE-Digital/dfe-analytics#26.
| it 'does not go out to the network' do | ||
| request = stub_analytics_event_submission | ||
|
|
||
| DfE::Analytics::Testing.fake! do |
There was a problem hiding this comment.
This block isn't necessary as it's the default state, set in the body of the Testing module (also a la sidekiq) — could rename spec and/or add something to the docs?
There was a problem hiding this comment.
Yeah it's true that this is default, but I wanted this test to be explicit in case that changes in the future. It's clear that whatever might change around this test, we're at least using the fake testing mode in it.
duncanjbrown
approved these changes
Jun 28, 2022
thomasleese
added a commit
to DFE-Digital/apply-for-qualified-teacher-status
that referenced
this pull request
Jun 30, 2022
This changes the way we disable DfE Analytics in our tests by using the built-in DfE Analytics fake testing mode. Note that this depends on DFE-Digital/dfe-analytics#26.
thomasleese
added a commit
to DFE-Digital/apply-for-qualified-teacher-status
that referenced
this pull request
Jun 30, 2022
This changes the way we disable DfE Analytics in our tests by using the built-in DfE Analytics fake testing mode. Note that this depends on DFE-Digital/dfe-analytics#26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes to the built-in testing modes to make them easier to use:
fake!currently doesn't work as the stubbedinsertmethod has the wrong signature.