Add .tool-versions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ya, I was thinking of the same. Would you be ok with using |
duncanjbrown
force-pushed
the
ruby-version
branch
from
d78deef to
6e1ffa4
Compare
|
Good shout. Amended! |
Because the async gem, which is a (distant) dependency of github_changelog_generator, introduces a Ruby version constraint of >=3.1.1 for the 2.x series, bundling on a machine with Ruby 3.1.1 installed will result in a different Gemfile.lock than bundling on a machine with an earlier Ruby version. Note than this is a development dependency only so the official supported ruby version is still 2.7. In fact the behaviour of bundler here is quite confusing because it says that async 2.x.x has been *withdrawn* by the author, which isn't actually true — it's just that the version in the Gemfile.lock can't be reconciled with the Ruby version you're running. They've already fixed it (but haven't released it yet afaics). rubygems/rubygems#5525 We use asdf everywhere else - use it here too
Adding .ruby-version made rubocop want to enforce 3.1 syntax, which isn't what we said we'd support in the gemspec (we said 2.3 (!)) - bump that to 2.7, which is the earliest minor version any of our live services use
duncanjbrown
force-pushed
the
ruby-version
branch
from
6e1ffa4 to
db01dad
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
asyncgem, which is a (distant) dependency ofgithub_changelog_generator, introduces a Ruby version constraint of>=3.1.1for the2.xseries, bundling on a machine with Ruby3.1.1installed will result in a differentGemfile.lock(ie withasync > 2) than bundling on a machine with an earlier Ruby version (which getsasync < 2). If you're in the second group and your colleague is in the first,bundle installfails with an unhelpful error:In fact the behaviour of bundler here is quite confusing because it says that
async (2.0.3)has been removed by the author, which isn't actually true — it's just that the version in theGemfile.lockcan't be reconciled with the local Ruby version. This incorrect error is a bug inbundler! They've fixed it, but haven't released it yet, afaics.rubygems/rubygems#5525
Note that this only affects dev environments:
github_changelog_generatoris a development dependency only so the official Ruby version supported bydfe-analyticsis still2.7.Alternative to pinning a Ruby version for dev is to explicitly depend on
async< 2.0in thegemspec, but that's a bit weird and mysterious considering it's not our direct dependency.