Standardise event-schema.json #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that if a schema in BQ lacks a field in our schema, it won’t cause an exception and the (presumably blank) field will just be dropped
misaka
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now one-size-fits-all for BAT services. It has some extra Apply-only bits (ie
namespace) — we can tidy that up if we ever want to.As schemas in BQ might lack fields we now send, this PR adds
ignore_unknownto the inserts, which makes the client silently drop fields instead of throwing exceptions. If and when schemas are standardised in BQ (we can in fact generate BQ schemas from the JSON) we can tighten this up again.