Remove ability to pseudonymise data #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericaporter
force-pushed
the
remove-pseudonymisation
branch
from
6993376 to
90cb0b6
Compare
ericaporter
commented
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer wish to support the ability to pseudonymise data in the gem since we now send it separately as hidden_pii.
This PR removes reference to pseudonymisation from the docs and the codebase.
N.B. I have left in the anonymise method in analytics.rb since it is being used by anonymised_user _agent_and_ip: anonymised_user_agent_and_ip(rack_request) which I have not removed at this stage.**
**N.B. For deployment, first check whether any service is still sending pseudonymised data... we would ideally have them sending that data as hidden_pii prior to deployment. Some general comms to services might be helpful