Update google_cloud_bigquery_setup.md #156
Merged
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added analytics hub permissions
remove space
asatwal
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This looks OK, but we should really turn this into a gcloud script shell script and commit to the teacher-services-analytics-cloud repo.
We should also make it a create/update script so that we can easily maintain roles. We already have the ability to run across all projects, so once we update the custom role we can then change it across all projects with a single invocation of a shell script.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added analytics hub permissions in Advanced and Basic custom role documentation