Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certain paths or endpoints to be excluded #154

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

ericaporter
Copy link
Contributor

Relates to this ticket

Almost all services have had to find a work around to exclude the /healthcheck endpoint from being included as a web_request event. Currently there is no way of excluding this through the gem.

This PR allows certain endpoints and paths to be excluded by allowing services to list these in their config file.

@ericaporter ericaporter requested a review from asatwal July 5, 2024 13:05
@ericaporter ericaporter self-assigned this Jul 5, 2024
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just one comment on the documentation that needs changing I believe before merging.

README.md Outdated Show resolved Hide resolved
@ericaporter ericaporter merged commit 7143f86 into main Jul 11, 2024
7 checks passed
@ericaporter ericaporter deleted the allow-exclusion-of-certain-endpoints branch July 11, 2024 13:09
@ericaporter ericaporter mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants