Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import_all_entities rake task output #147

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

slorek
Copy link
Collaborator

@slorek slorek commented Jun 4, 2024

When enable_analytics is true the import_all_entities rake task outputs a confusing message stating that it is not enabled, but nonetheless continues to perform the task:

$ bundle exec rails dfe:analytics:import_all_entities
DfE Analytics is not enabled - Ignoring import_all_entities

This fix should avoid some confusion for users! :)

Copy link
Contributor

@ericaporter ericaporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ericaporter ericaporter merged commit 1ef5b2d into main Jun 24, 2024
7 checks passed
@ericaporter ericaporter deleted the fix-rake-output-message branch June 24, 2024 14:28
@ericaporter ericaporter mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants