Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for service pattern name spacing issue #137

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions lib/dfe/analytics/shared/service_pattern.rb
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
# a template for creating service objects
module ServicePattern
def self.included(base)
base.extend(ClassMethods)
base.class_eval do
private_class_method(:new)
end
end
module DfE
module Analytics
# a template for creating service objects
module ServicePattern
def self.included(base)
base.extend(ClassMethods)
base.class_eval do
private_class_method(:new)
end
end

def call
raise(NotImplementedError('#call must be implemented'))
end
def call
raise(NotImplementedError('#call must be implemented'))
end

# provides class-level methods to the classes that include ServicePattern
# defines a template for the `call` method; the expected entry point for service objects
module ClassMethods
def call(*args, **keyword_args, &block)
return new.call if args.empty? && keyword_args.empty? && block.nil?
# provides class-level methods to the classes that include ServicePattern
# defines a template for the `call` method; the expected entry point for service objects
module ClassMethods
def call(*args, **keyword_args, &block)
return new.call if args.empty? && keyword_args.empty? && block.nil?

new(*args, **keyword_args, &block).call
new(*args, **keyword_args, &block).call
end
end
end
end
end
Loading