Add flags to prevent code running in envs where dfe-analytics isn't set up #130
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericaporter
force-pushed
the
add-analytics-enabled-check
branch
from
4c5b24f to
c805f9d
Compare
ericaporter
commented
Apr 12, 2024
ericaporter
commented
Apr 12, 2024
asatwal
reviewed
Apr 16, 2024
asatwal
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events are being triggered on Register Sandbox env which isn't set up to send events to BigQuery. This is causing issues with lots of erroring jobs in Sentry, lots of emails, noise etc.
Adding in these flags should prevent events from sending in both the bulk upload and the entity table check job unless the env is set up.