Add order by clause to ensure consistent ordering #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericaporter
commented
Mar 12, 2024
|
|
||
| [select_clause, order_by_clause] | ||
| end | ||
|
|
There was a problem hiding this comment.
I could extract these two methods and put them into a shared module
There was a problem hiding this comment.
That would be a nice to have :-)
asatwal
approved these changes
Mar 12, 2024
|
|
||
| [select_clause, order_by_clause] | ||
| end | ||
|
|
There was a problem hiding this comment.
That would be a nice to have :-)
ericaporter
force-pushed
the
update-checksum-ordering
branch
from
712b3a6 to
b398102
Compare
ericaporter
force-pushed
the
update-checksum-ordering
branch
from
b398102 to
6c79743
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix an issue we have with periodic mismatching of checksums - which might be arising due to a lack of enforced ordering