Use original_fullpath for request path #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the event to get the request path from the `original_fullpath` method rather than the `path` method. I'm making this change as the `original_fullpath` represents the path of the page as requested by the user, not necessarily the page being rendered. In most cases the original path and the path will be the same, but there are some scenarios where it is. Specifically, when rendering a custom error page in Rails which is mounted at `/404` the path ends up being the value `/404` rather than the path which triggered the 404 page.
asatwal
approved these changes
Feb 21, 2024
|
Thanks @asatwal - I've merged this in. I don't think it needs to be released any time soon so it can wait until the next release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the event to get the request path from the
original_fullpathmethod rather than thepathmethod. I'm making this change as theoriginal_fullpathrepresents the path of the page as requested by the user, not necessarily the page being rendered.In most cases the original path and the path will be the same, but there are some scenarios where it is. Specifically, when rendering a custom error page in Rails which is mounted at
/404the path ends up being the value/404rather than the path which triggered the 404 page.