Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional to handle 'postgis' db #109

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

ericaporter
Copy link
Contributor

Teaching vacancies use PostGIS as a db which extends the capabilities of the PostgreSQL.

The Entity Table check job is not running for them on their review app as it point to production and the adapter_name is postgis. In production the job also won't run because the conditional returns false unless it is postgres in production.

This PR updates the conditional so that the job will run if the adapter_name is postgis. This shouldn't cause any issues as postgis is an extension of postgres and so the lookup should run as it would on postgres

@ericaporter ericaporter requested a review from asatwal January 26, 2024 15:40
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@ericaporter ericaporter merged commit dad64e7 into main Jan 29, 2024
7 checks passed
@ericaporter ericaporter deleted the update-entity-check-job-for-postgis branch January 29, 2024 15:42
@ericaporter ericaporter mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants