Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure order by column is in analytics.yml #106

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

ericaporter
Copy link
Contributor

We are now dynamically finding the order by column for the entity since sometimes updated_at is missing.

Instead of only checking the model for the existence of the order_by fields, we are now ensuring that they exist in the analytics.yml.

The logic has been updated so that we are from within the determine_order_column method ->

  1. finding the entity keys on the allow list
  2. returning unless an order column exists i.e. whether updated_at / created_at / id exists in the analytics.yml
  3. adding an additional check that the column exists both on the model and in the analytics.yml

@ericaporter ericaporter requested a review from asatwal January 5, 2024 11:37
@ericaporter ericaporter self-assigned this Jan 5, 2024
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ericaporter ericaporter merged commit a757f60 into main Jan 8, 2024
7 checks passed
@ericaporter ericaporter deleted the ensure-order-by-fields-are-in-yml branch January 8, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants