Add config options: queue name, BQ timeout, BQ retries #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaka
reviewed
Apr 21, 2022
lib/dfe/analytics/testing/helpers.rb
Outdated
| @@ -36,6 +36,17 @@ def stub_analytics_event_submission | |||
| stub_request(:post, /bigquery.googleapis.com/) | |||
| .to_return(status: 200, body: '{}', headers: { 'Content-Type' => 'application/json' }) | |||
| end | |||
|
|
|||
| def with_analytics_config(options) | |||
| old_config = DfE::Analytics.config | |||
There was a problem hiding this comment.
DfE::Analytics.config and old_config are the same thing (Ruby is pass by reference 😛 , see pry session below), so you should probably dup config:
Suggested change
| old_config = DfE::Analytics.config | |
| old_config = DfE::Analytics.config.dup |
Pry session:
From: /Users/misaka/Code/DfE/dfe-analytics/lib/dfe/analytics/testing/helpers.rb:48 DfE::Analytics::Testing::Helpers#with_analytics_config:
40: def with_analytics_config(options)
41: old_config = DfE::Analytics.config
42: DfE::Analytics.configure do |config|
43: options.each { |option, value| config[option] = value }
44: end
45:
46: yield
47: ensure
=> 48: binding.pry
49: DfE::Analytics.instance_variable_set(:@config, old_config)
50: end
[1] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> options
=> {:queue=>:my_custom_queue}
[2] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> DfE::Analytics.config[:queue]
=> :my_custom_queue
[3] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> old_config[:queue]
=> :my_custom_queue
Proof dup works:
[41] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> old_config = DfE::Analytics.config.dup
=> #<struct
...
queue=:default,
...>
[42] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> DfE::Analytics.config[:queue] = :my_custom_queue
=> :my_custom_queue
[43] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> old_config[:queue]
=> :default
[44] pry(#<RSpec::ExampleGroups::AnalyticsFlow::WhenAQueueIsSpecified>)> DfE::Analytics.config[:queue]
=> :my_custom_queue
There was a problem hiding this comment.
Very good point, thank you!
There was a problem hiding this comment.
lesson: test your tests
duncanjbrown
force-pushed
the
more-config-options
branch
from
815f22c to
d58f3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients can now configure the ActiveJob queue name, plus the BigQuery timeout and retry count options.