Skip to content

Commit

Permalink
Resolve undefined method migration_context when upgrading to rails …
Browse files Browse the repository at this point in the history
…7.2 (#162)

* Add rails 7.2 appraise
* Add CI test for rails 7.2
* Appraisal install
* Fixture path is deprecated
* Remove ruby 2.7 tests
* Add test for rails 7.1 or lower
  • Loading branch information
avinhurry authored Aug 16, 2024
1 parent c21a061 commit ad15381
Show file tree
Hide file tree
Showing 12 changed files with 607 additions and 79 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
name: Run specs
strategy:
matrix:
ruby-version: ['2.7', '3.1']
rails-version: ['rails-6', 'rails-6.1', 'rails-7']
ruby-version: ['3.1']
rails-version: ['rails-6', 'rails-6.1', 'rails-7', 'rails-7.2']
env:
BUNDLE_WITHOUT: release
steps:
Expand Down
5 changes: 5 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,8 @@ end
appraise "rails-7" do
gem "rails", "7.0.4"
end

appraise "rails-7.2" do
gem "rails", "7.2"
gem "rspec-rails", "6.1.3"
end
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ DEPENDENCIES
json-schema (~> 2.8)
pry (~> 0)
rails (>= 6)
rspec-rails (~> 5.0)
rspec-rails
rubocop (~> 1.54)
rubocop-rspec (~> 2.22)
solargraph
Expand Down
2 changes: 1 addition & 1 deletion dfe-analytics.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'json-schema', '~> 2.8'
spec.add_development_dependency 'pry', '~> 0'
spec.add_development_dependency 'rails', '>= 6'
spec.add_development_dependency 'rspec-rails', '~> 5.0'
spec.add_development_dependency 'rspec-rails'
spec.add_development_dependency 'rubocop', '~> 1.54'
spec.add_development_dependency 'rubocop-rspec', '~> 2.22'
spec.add_development_dependency 'solargraph'
Expand Down
62 changes: 38 additions & 24 deletions gemfiles/rails_6.1.gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
PATH
remote: ..
specs:
dfe-analytics (1.10.0)
dfe-analytics (1.14.0)
google-cloud-bigquery (~> 1.38)
httparty (~> 0.21)
multi_xml (~> 0.6.0)
request_store_rails (~> 2)

GEM
Expand Down Expand Up @@ -95,7 +97,9 @@ GEM
async-pool (0.4.0)
async (>= 1.25)
backport (1.2.0)
base64 (0.2.0)
benchmark (0.2.1)
bigdecimal (3.1.8)
builder (3.2.4)
coderay (1.1.3)
concurrent-ruby (1.2.2)
Expand All @@ -105,6 +109,7 @@ GEM
crack (0.4.5)
rexml
crass (1.0.6)
csv (3.3.0)
date (3.3.3)
debug (1.8.0)
irb (>= 1.5.0)
Expand Down Expand Up @@ -133,37 +138,42 @@ GEM
rake (>= 10.0)
globalid (1.1.0)
activesupport (>= 5.0)
google-apis-bigquery_v2 (0.55.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-core (0.11.0)
google-apis-bigquery_v2 (0.75.0)
google-apis-core (>= 0.15.0, < 2.a)
google-apis-core (0.15.1)
addressable (~> 2.5, >= 2.5.1)
googleauth (>= 0.16.2, < 2.a)
httpclient (>= 2.8.1, < 3.a)
googleauth (~> 1.9)
httpclient (>= 2.8.3, < 3.a)
mini_mime (~> 1.0)
mutex_m
representable (~> 3.0)
retriable (>= 2.0, < 4.a)
rexml
webrick
google-cloud-bigquery (1.43.1)
google-cloud-bigquery (1.50.0)
bigdecimal (~> 3.0)
concurrent-ruby (~> 1.0)
google-apis-bigquery_v2 (~> 0.1)
google-apis-bigquery_v2 (~> 0.71)
google-apis-core (~> 0.13)
google-cloud-core (~> 1.6)
googleauth (>= 0.16.2, < 2.a)
googleauth (~> 1.9)
mini_mime (~> 1.0)
google-cloud-core (1.6.0)
google-cloud-env (~> 1.0)
google-cloud-core (1.7.1)
google-cloud-env (>= 1.0, < 3.a)
google-cloud-errors (~> 1.0)
google-cloud-env (1.6.0)
faraday (>= 0.17.3, < 3.0)
google-cloud-errors (1.3.1)
googleauth (1.6.0)
faraday (>= 0.17.3, < 3.a)
google-cloud-env (2.1.1)
faraday (>= 1.0, < 3.a)
google-cloud-errors (1.4.0)
googleauth (1.11.0)
faraday (>= 1.0, < 3.a)
google-cloud-env (~> 2.1)
jwt (>= 1.4, < 3.0)
memoist (~> 0.16)
multi_json (~> 1.11)
os (>= 0.9, < 2.0)
signet (>= 0.16, < 2.a)
hashdiff (1.0.1)
httparty (0.22.0)
csv
mini_mime (>= 1.0.0)
multi_xml (>= 0.5.2)
httpclient (2.8.3)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
Expand All @@ -175,7 +185,8 @@ GEM
json (2.6.3)
json-schema (2.8.1)
addressable (>= 2.4)
jwt (2.7.1)
jwt (2.8.2)
base64
kramdown (2.4.0)
rexml
kramdown-parser-gfm (1.1.0)
Expand All @@ -190,11 +201,12 @@ GEM
net-pop
net-smtp
marcel (1.0.2)
memoist (0.16.2)
method_source (1.0.0)
mini_mime (1.1.2)
minitest (5.18.1)
multi_json (1.15.0)
multi_xml (0.6.0)
mutex_m (0.2.0)
net-imap (0.3.6)
date
net-protocol
Expand Down Expand Up @@ -319,7 +331,7 @@ GEM
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
signet (0.17.0)
signet (0.19.0)
addressable (~> 2.8)
faraday (>= 0.17.5, < 3.a)
jwt (>= 1.5, < 3.0)
Expand Down Expand Up @@ -351,6 +363,7 @@ GEM
sqlite3 (1.6.3-x86_64-darwin)
thor (1.2.2)
tilt (2.2.0)
timecop (0.9.10)
timeout (0.4.0)
timers (4.3.5)
traces (0.11.1)
Expand All @@ -363,7 +376,6 @@ GEM
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.8.1)
websocket-driver (0.7.5)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand All @@ -374,6 +386,7 @@ GEM

PLATFORMS
arm64-darwin-21
arm64-darwin-23
x86_64-darwin-22

DEPENDENCIES
Expand All @@ -385,11 +398,12 @@ DEPENDENCIES
json-schema (~> 2.8)
pry (~> 0)
rails (= 6.1.7)
rspec-rails (~> 5.0)
rspec-rails
rubocop (~> 1.54)
rubocop-rspec (~> 2.22)
solargraph
sqlite3
timecop
webmock (~> 3.14)
with_model

Expand Down
62 changes: 38 additions & 24 deletions gemfiles/rails_6.gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
PATH
remote: ..
specs:
dfe-analytics (1.10.0)
dfe-analytics (1.14.0)
google-cloud-bigquery (~> 1.38)
httparty (~> 0.21)
multi_xml (~> 0.6.0)
request_store_rails (~> 2)

GEM
Expand Down Expand Up @@ -91,7 +93,9 @@ GEM
async-pool (0.4.0)
async (>= 1.25)
backport (1.2.0)
base64 (0.2.0)
benchmark (0.2.1)
bigdecimal (3.1.8)
builder (3.2.4)
coderay (1.1.3)
concurrent-ruby (1.2.2)
Expand All @@ -101,6 +105,7 @@ GEM
crack (0.4.5)
rexml
crass (1.0.6)
csv (3.3.0)
date (3.3.3)
debug (1.8.0)
irb (>= 1.5.0)
Expand Down Expand Up @@ -129,37 +134,42 @@ GEM
rake (>= 10.0)
globalid (1.1.0)
activesupport (>= 5.0)
google-apis-bigquery_v2 (0.55.0)
google-apis-core (>= 0.11.0, < 2.a)
google-apis-core (0.11.0)
google-apis-bigquery_v2 (0.75.0)
google-apis-core (>= 0.15.0, < 2.a)
google-apis-core (0.15.1)
addressable (~> 2.5, >= 2.5.1)
googleauth (>= 0.16.2, < 2.a)
httpclient (>= 2.8.1, < 3.a)
googleauth (~> 1.9)
httpclient (>= 2.8.3, < 3.a)
mini_mime (~> 1.0)
mutex_m
representable (~> 3.0)
retriable (>= 2.0, < 4.a)
rexml
webrick
google-cloud-bigquery (1.43.1)
google-cloud-bigquery (1.50.0)
bigdecimal (~> 3.0)
concurrent-ruby (~> 1.0)
google-apis-bigquery_v2 (~> 0.1)
google-apis-bigquery_v2 (~> 0.71)
google-apis-core (~> 0.13)
google-cloud-core (~> 1.6)
googleauth (>= 0.16.2, < 2.a)
googleauth (~> 1.9)
mini_mime (~> 1.0)
google-cloud-core (1.6.0)
google-cloud-env (~> 1.0)
google-cloud-core (1.7.1)
google-cloud-env (>= 1.0, < 3.a)
google-cloud-errors (~> 1.0)
google-cloud-env (1.6.0)
faraday (>= 0.17.3, < 3.0)
google-cloud-errors (1.3.1)
googleauth (1.6.0)
faraday (>= 0.17.3, < 3.a)
google-cloud-env (2.1.1)
faraday (>= 1.0, < 3.a)
google-cloud-errors (1.4.0)
googleauth (1.11.0)
faraday (>= 1.0, < 3.a)
google-cloud-env (~> 2.1)
jwt (>= 1.4, < 3.0)
memoist (~> 0.16)
multi_json (~> 1.11)
os (>= 0.9, < 2.0)
signet (>= 0.16, < 2.a)
hashdiff (1.0.1)
httparty (0.22.0)
csv
mini_mime (>= 1.0.0)
multi_xml (>= 0.5.2)
httpclient (2.8.3)
i18n (1.14.1)
concurrent-ruby (~> 1.0)
Expand All @@ -171,7 +181,8 @@ GEM
json (2.6.3)
json-schema (2.8.1)
addressable (>= 2.4)
jwt (2.7.1)
jwt (2.8.2)
base64
kramdown (2.4.0)
rexml
kramdown-parser-gfm (1.1.0)
Expand All @@ -186,11 +197,12 @@ GEM
net-pop
net-smtp
marcel (1.0.2)
memoist (0.16.2)
method_source (1.0.0)
mini_mime (1.1.2)
minitest (5.18.1)
multi_json (1.15.0)
multi_xml (0.6.0)
mutex_m (0.2.0)
net-imap (0.3.6)
date
net-protocol
Expand Down Expand Up @@ -316,7 +328,7 @@ GEM
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (>= 0.17.3, < 3)
signet (0.17.0)
signet (0.19.0)
addressable (~> 2.8)
faraday (>= 0.17.5, < 3.a)
jwt (>= 1.5, < 3.0)
Expand Down Expand Up @@ -349,6 +361,7 @@ GEM
thor (1.2.2)
thread_safe (0.3.6)
tilt (2.2.0)
timecop (0.9.10)
timeout (0.4.0)
timers (4.3.5)
traces (0.11.1)
Expand All @@ -361,7 +374,6 @@ GEM
addressable (>= 2.8.0)
crack (>= 0.3.2)
hashdiff (>= 0.4.0, < 2.0.0)
webrick (1.8.1)
websocket-driver (0.7.5)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
Expand All @@ -372,6 +384,7 @@ GEM

PLATFORMS
arm64-darwin-21
arm64-darwin-23
x86_64-darwin-22

DEPENDENCIES
Expand All @@ -384,11 +397,12 @@ DEPENDENCIES
pry (~> 0)
psych (< 4)
rails (= 6.0.6)
rspec-rails (~> 5.0)
rspec-rails
rubocop (~> 1.54)
rubocop-rspec (~> 2.22)
solargraph
sqlite3
timecop
webmock (~> 3.14)
with_model

Expand Down
13 changes: 13 additions & 0 deletions gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "rails", "7.2"
gem "rspec-rails", "6.1.3"

group :release do
gem "gem-release", require: false
gem "github_changelog_generator", require: false
end

gemspec path: "../"
Loading

0 comments on commit ad15381

Please sign in to comment.