Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUPEYALPHA-1036] Admin One Login IDV #3180

Merged
merged 10 commits into from
Sep 20, 2024
Merged

[LUPEYALPHA-1036] Admin One Login IDV #3180

merged 10 commits into from
Sep 20, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Sep 11, 2024

Context

Changes

  • If user used OL, display their OL IDV data and opposing data from their claim in ID task
  • If data matches it auto passes
  • if data does not match it fails
  • also on claim submission we do the same check and if it fails do not send the provider the verification email

Screenshots

Screenshot 2024-09-18 at 15 39 09


Screenshot 2024-09-18 at 15 39 19

@asmega asmega added the deploy Deploy a review app for this PR label Sep 11, 2024
@asmega asmega changed the title Admin fe idv [LUPEYALPHA-1036] Admin One Login IDV Sep 11, 2024
@asmega asmega removed the deploy Deploy a review app for this PR label Sep 11, 2024
@asmega asmega added the deploy Deploy a review app for this PR label Sep 11, 2024
def one_login
if claim.identity_confirmed_with_onelogin?
if claim.onelogin_idv_full_name.downcase == claim.full_name.downcase && claim.onelogin_idv_date_of_birth == claim.date_of_birth
create_task(match: nil, passed: true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if task needs other data on it? eg should match be populated?

Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

app/models/automated_checks/claim_verifiers/identity.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes look good to me 👍

@asmega asmega merged commit f9189a6 into master Sep 20, 2024
14 checks passed
@asmega asmega deleted the admin-fe-idv branch September 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants